[Pipeliner] Handle masking for atomic_rmw #5231
Open
+75
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scxiao
force-pushed
the
atomic_rmw_mask
branch
from
82b559f
to
d59dd74
Compare
antiagainst
requested changes
Nov 23, 2024
|
|
||
| // Check that the stream pipeliner updates atomic op in the k-loop correctly | ||
| // CHECK-LABEL: _triton_gemm_kernel_atomic_rmw | ||
| // CHECK: tt.atomic_rmw fadd, acq_rel, gpu |
There was a problem hiding this comment.
Can you also insert CHECK: lines for the loop structure scf.for and scf.yield to be clear? Like L36 - L42.
There was a problem hiding this comment.
thanks for the comments, added.
antiagainst
changed the title
scxiao
force-pushed
the
atomic_rmw_mask
branch
from
d59dd74
to
a50c820
Compare
antiagainst
approved these changes
Nov 25, 2024
|
@zhanglx13, could you please help trigger a CI build and then merge this PR? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support atomic_rmw in the function
predicateOpto mask operations during scheduling.New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)