Adding tl.const annotation to mark and validate that const tensors are not being stored to #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebar
reviewed
Mar 12, 2024
ThomasRaoux
approved these changes
Mar 13, 2024
|
tl.const sgtm |
ptillet
reviewed
Mar 14, 2024
pawelszczerbuk
commented
Mar 14, 2024
ptillet
pushed a commit
that referenced
this pull request
Mar 18, 2024
…e not being stored to (#3360) Introducing `tl.const` argument annotation for marking pointers to constant memory. Tensors in memory accessed through such pointers cannot be modified (you cannot call `store` with const pointer).
ptillet
pushed a commit
that referenced
this pull request
Apr 1, 2024
…e not being stored to (#3360) Introducing `tl.const` argument annotation for marking pointers to constant memory. Tensors in memory accessed through such pointers cannot be modified (you cannot call `store` with const pointer).
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
…e not being stored to (triton-lang#3360) Introducing `tl.const` argument annotation for marking pointers to constant memory. Tensors in memory accessed through such pointers cannot be modified (you cannot call `store` with const pointer).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing
tl.constargument annotation for marking pointers to constant memory. Tensors in memory accessed through such pointers cannot be modified (you cannot callstorewith const pointer).