Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SETUP] Fixed dependencies #1389

Merged
merged 4 commits into from
Mar 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,12 @@ jobs:
- name: Install Triton
run: |
cd python
pip3 install cmake==3.24
TRITON_USE_ASSERT_ENABLED_LLVM=TRUE pip3 install -e '.[tests]'

- name: Run lit tests
run: |
pip3 install lit
cd python
LIT_TEST_DIR="build/$(ls build)/test"
if [ ! -d "$LIT_TEST_DIR" ]; then
Expand Down
19 changes: 15 additions & 4 deletions python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,19 +211,25 @@ def build_extension(self, ext):

download_and_copy_ptxas()


setup(
name="triton",
version="2.1.0",
author="Philippe Tillet",
author_email="[email protected]",
description="A language and compiler for custom Deep Learning operations",
long_description="",
packages=["triton", "triton/_C", "triton/language", "triton/tools", "triton/impl", "triton/ops", "triton/runtime", "triton/ops/blocksparse"],
packages=[
"triton",
"triton/_C",
"triton/language",
"triton/tools",
"triton/impl",
"triton/ops",
"triton/runtime",
"triton/ops/blocksparse"],
install_requires=[
"cmake>=3.20",
"filelock",
"torch",
"lit",
],
package_data={"triton": ["third_party/**/*"]},
include_package_data=True,
Expand All @@ -242,13 +248,18 @@ def build_extension(self, ext):
],
test_suite="tests",
extras_require={
"build": [
"cmake>=3.20",
"lit",
],
"tests": [
"autopep8",
"flake8",
"isort",
"numpy",
"pytest",
"scipy>=1.7.1",
"torch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that installing just triton on a fresh environment without torch won't work except if we pass the test argument as well
https://github.com/openai/triton/blob/3239c93a934d3e8d431da00d9076e7f9b6d7f69d/python/triton/__init__.py#L9
Probably worth at least a note in the documentation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'm working on fixing that now :)

],
"tutorials": [
"matplotlib",
Expand Down