Bump OTel version from v1.8.3 to v1.11.0 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-kmcgill53
approved these changes
Aug 24, 2023
pvijayakrish
pushed a commit
that referenced
this pull request
Oct 8, 2024
* ifdef out kUINT8 based on TRT version * Fix up * Use NV_TENSORRT_MAJOR and NV_TENSORRT_MINOR instead * Revert changes. Add comment for FIXME * Fix version compiled issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for the record:
can't use v1.10.0, it doesn't compile due to this: open-telemetry/opentelemetry-cpp#2274
-DBUILD_SHARED_LIBS:STRING=OFFis required, otherwise opentelemetry will buildlibopentelemetry_protoas a shared library.