Skip to content

Commit

Permalink
Change network.transport from recommended to opt-in in the HTTP sem…
Browse files Browse the repository at this point in the history
…conv (open-telemetry#402)

Co-authored-by: Joao Grassi <[email protected]>
  • Loading branch information
2 people authored and trisch-me committed Oct 17, 2023
1 parent c9ff0e4 commit d8afa1e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ release.
([#374](https://github.com/open-telemetry/semantic-conventions/pull/374))
- BREAKING: Define url.scheme in terms of logical operation in HTTP server semconv.
([#376](https://github.com/open-telemetry/semantic-conventions/pull/376))
- BREAKING: Change `network.transport` from recommended to opt-in in HTTP semconv.
([#402](https://github.com/open-telemetry/semantic-conventions/pull/402))

### Features

Expand Down
6 changes: 4 additions & 2 deletions model/trace/http.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@ groups:
sampling_relevant: true
requirement_level: required
- ref: network.transport
requirement_level:
conditionally_required: If not default (`tcp` for `HTTP/1.1` and `HTTP/2`, `udp` for `HTTP/3`).
requirement_level: opt_in
note: >
Generally `tcp` for `HTTP/1.0`, `HTTP/1.1`, and `HTTP/2`. Generally `udp` for `HTTP/3`.
Other obscure implementations are possible.
- ref: network.type
- ref: user_agent.original

Expand Down

0 comments on commit d8afa1e

Please sign in to comment.