Update links to trisa.dev #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellemaxwell
commented
Jun 4, 2024
| @@ -75,7 +75,7 @@ const LandingHeader = (props: FlexProps): JSX.Element => { | |||
| <Stack pr={2}> | |||
| <LanguagesDropdown /> | |||
| </Stack> | |||
| <MenuItem to="https://trisa.io" data-testid="about"> | |||
| <MenuItem to="https://trisa.dev/reference/faq/index.html" data-testid="about"> | |||
There was a problem hiding this comment.
I thought navigating users to the FAQ page where links say About TRISA or something similar would be helpful so that they won't have to spend much time navigating trisa.dev to find what they're looking for.
daniellemaxwell
commented
Jun 4, 2024
| @@ -125,7 +125,7 @@ const JoinUsSection: React.FC = () => { | |||
| border="2px solid #fff" | |||
| _hover={{ bg: '#24a9df' }} | |||
| as="a" | |||
| href="https://trisa.io/members/" | |||
| href="https://trisa.dev" | |||
There was a problem hiding this comment.
Should we continue to display the info about a member list or temporarily hide it until we're able to show the list again?
There was a problem hiding this comment.
Let's temporarily hide it.
bbengfort
approved these changes
Jun 4, 2024
| @@ -125,7 +125,7 @@ const JoinUsSection: React.FC = () => { | |||
| border="2px solid #fff" | |||
| _hover={{ bg: '#24a9df' }} | |||
| as="a" | |||
| href="https://trisa.io/members/" | |||
| href="https://trisa.dev" | |||
There was a problem hiding this comment.
Let's temporarily hide it.
| @@ -75,7 +75,7 @@ const LandingHeader = (props: FlexProps): JSX.Element => { | |||
| <Stack pr={2}> | |||
| <LanguagesDropdown /> | |||
| </Stack> | |||
| <MenuItem to="https://trisa.io" data-testid="about"> | |||
| <MenuItem to="https://trisa.dev/reference/faq/index.html" data-testid="about"> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
This PR replaces
trisa.iolinks withtrisa.dev, updates the support email address, and updates the footer copy.The changes required an update to a test, so all snapshot (.snap) files included here don't need to be reviewed. Also, the
.pofiles have also been updated and those also won't require a review.Type of change
Acceptance criteria
https://www.awesomescreenshot.com/video/28316291?key=5c0ad8034af68de44f25fd8684e47a82
Author checklist
Reviewer(s) checklist