Set review stepper state to complete after user submits registration #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellemaxwell
commented
Feb 28, 2024
| @@ -71,6 +72,11 @@ const ReviewSubmit: React.FC<ReviewSubmitProps> = ({ | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
| }, [isSent]); | |||
|
|
|||
| // Update the review step status to complete if the user submits a registration. | |||
| if (isTestNetSubmitted || isMainNetSubmitted) { | |||
There was a problem hiding this comment.
The stepper label color doesn't immediately update after the registration is submitted. To fix this, I think react-query will have to be used which would require some refactoring that should be handled in a separate story.
pdeziel
approved these changes
Mar 4, 2024
| @@ -71,6 +72,11 @@ const ReviewSubmit: React.FC<ReviewSubmitProps> = ({ | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
| }, [isSent]); | |||
|
|
|||
| // Update the review step status to complete if the user submits a registration. | |||
| if (isTestNetSubmitted || isMainNetSubmitted) { | |||
| dispatch(setStepStatus({ step: 6, status: LSTATUS.COMPLETE })); | |||
There was a problem hiding this comment.
What is the significance of the 6? Is it the step number?
There was a problem hiding this comment.
Yes, 6 is the review step number. There are constants for steps 1-5. I was unable to determine why 6 was excluded, since 6 is listed as a step number a few times in the code. However, I did notice some cases where the constants weren't used for other step numbers, so a story updating this should be added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Sets the stepper status to complete after a user submits the registration form.
Type of change
Acceptance criteria
https://www.awesomescreenshot.com/video/25370460?key=2b8264fa9105338e9f47cf1ebeb01572
Author checklist
Reviewer(s) checklist