Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom toast component #1146

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Replace custom toast component #1146

merged 4 commits into from
Jan 18, 2024

Conversation

daniellemaxwell
Copy link
Collaborator

@daniellemaxwell daniellemaxwell commented Jan 18, 2024

Scope of changes

Fix the following error, Error: Objects are not valid as a React child , by replacing a custom toast component with the Chakra UI toast component.

The changes also ensure the Add Collaborator modal completely closes after a user experiences an error and displays the error message provided from the BE. Error messaging was updated in the Edit Collaborator form as well to resolve an error caused by updating the axiosInstance to return error responses.

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

Note: The inspector was open while recording the video below to confirm that the error messages didn't appear in the console. This is why the modal may appear to not fit the screen.

https://www.awesomescreenshot.com/video/24167192?key=96d5767d73b78c0b8adda5a190d63267

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@daniellemaxwell daniellemaxwell changed the title Sc 23373 Replace custom toast component Jan 18, 2024
Copy link
Collaborator

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on a roll squashing bugs this week!

@bbengfort bbengfort merged commit 4bcceab into main Jan 18, 2024
15 checks passed
@bbengfort bbengfort deleted the sc-23373 branch January 18, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants