Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish and Portuguese to lingui locales #1143

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

daniellemaxwell
Copy link
Collaborator

@daniellemaxwell daniellemaxwell commented Jan 17, 2024

Scope of changes

Add Spanish and Portuguese to locales in lingui config. Also, runs an extraction to create .po files where translations will be added for both languages.

Type of change

  • bug fix
  • new feature
  • documentation
  • other (internationalization)

Acceptance criteria

Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Copy link
Collaborator

@rebeccabilbro rebeccabilbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @daniellemaxwell ! Thank you for laying the groundwork for these new doc translations!

@daniellemaxwell daniellemaxwell merged commit 01eb917 into main Jan 18, 2024
15 checks passed
@daniellemaxwell daniellemaxwell deleted the sc-23361 branch January 18, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants