fix tests

pkg/bff/activity_test.go

@@ -135,6 +135,7 @@ func (s *bffTestSuite) TestActivitySubscriber() {
 	// Test running the subscriber under a waitgroup
 	conf.Topic = "network-activity"
 	conf.Testing = true
+	conf.Network = activity.TestNet
 	conf.Ensign = ensign.Config{
 		ClientID:     "client-id",
 		ClientSecret: "client-secret",

pkg/utils/activity/config_test.go

@@ -35,6 +35,7 @@ func TestActivityValidation(t *testing.T) {
 
 	// Test valid enabled configuration
 	conf.Enabled = true
+	conf.Network = activity.TestNet
 	conf.Ensign.ClientID = "client-id"
 	require.NoError(t, conf.Validate())
 }

pkg/utils/activity/event.go

@@ -119,9 +119,6 @@ func (n Network) String() string {
 }
 
 // Check if the network is valid.
-// NOTE: this method must be named Validate and not Validate to prevent confire from
-// calling this function during validation. Configurations that use a Network should
-// manually call Validate in their Validation method.
 func (n Network) Validate() error {
 	if n == UnknownNetwork {
 		return ErrUnknownNetwork

pkg/utils/activity/publisher_test.go

@@ -28,7 +28,7 @@ func TestPublisher(t *testing.T) {
 		Enabled:           true,
 		AggregationWindow: time.Minute * 5,
 	}
-	require.ErrorIs(t, activity.ErrMissingTopic, activity.Start(conf), "expected missing topic error")
+	require.Error(t, activity.Start(conf), "expected error with bad configuration")
 
 	// Test publisher in disabled mode starts
 	activity.Reset()

pkg/utils/ensign/config.go

@@ -17,9 +17,6 @@ type Config struct {
 }
 
 // Validate that the ensign config is ready for connection.
-// NOTE: This must be Validate() and not Validate() to prevent confire from calling
-// this function to check if the configuration is valid. Configurations that embed an
-// ensign configuration should manually call Validate in their Validation method.
 func (c Config) Validate() (err error) {
 	if c.Testing {
 		return nil