Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TL-36484: Add fledge signaling #79

Merged
merged 19 commits into from
Jun 22, 2023
Merged

Conversation

patrickloughrey
Copy link

Type of change

  • Feature

Description of change

  • Triplelift is not entirely ready to support Fledge end to end but we do want to start ingesting and tracking fledgeEnabled signals that publishers are setting in the meantime

@patrickloughrey patrickloughrey self-assigned this Jun 9, 2023
@@ -56,6 +56,10 @@ export const tripleliftAdapterSpec = {
tlCall = tryAppendQueryString(tlCall, 'us_privacy', bidderRequest.uspConsent);
}

if (bidderRequest && bidderRequest.fledgeEnabled && bidderRequest.fledgeEnabled == true) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed && bidderRequest.fledgeEnabled == true because bidderRequest.fledgeEnabled already checks that. I've tested this on the browser.
Screen Shot 2023-06-22 at 10 44 39 AM

@nllerandi3lift
Copy link

@patrickloughrey g2g

@nllerandi3lift
Copy link

I'm actually going to merge just to check for merge conflicts since there's a second PR (gpp stuff) to look at.

@nllerandi3lift nllerandi3lift merged commit 0e76a07 into master Jun 22, 2023
@nllerandi3lift nllerandi3lift deleted the TL-36484-Fledge-Signals branch June 22, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants