Concert Bid Adapter: Update localStorage name-spacing for Concert UID (…

…prebid#9158) * collect EIDs for bid request * add ad slot positioning to payload * RPO-2012: Update local storage name-spacing for c_uid (#8) * Updates c_uid namespacing to be more specific for concert * fixes unit tests * remove console.log * RPO-2012: Add check for shared id (#9) * Adds check for sharedId * Updates cookie name * remove trailing comma Co-authored-by: antoin <[email protected]> Co-authored-by: Antoin <[email protected]>
triplelift-internal · Nov 8, 2022 · fe23164 · fe23164
1 parent 6d114e8
commit fe23164
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 18 deletions.
diff --git a/modules/concertBidAdapter.js b/modules/concertBidAdapter.js
@@ -1,4 +1,4 @@
-import { logWarn, logMessage, debugTurnedOn, generateUUID } from '../src/utils.js';
+import { logWarn, logMessage, debugTurnedOn, generateUUID, deepAccess } from '../src/utils.js';
 import { registerBidder } from '../src/adapters/bidderFactory.js';
 import { getStorageManager } from '../src/storageManager.js';
 import { hasPurpose1Consent } from '../src/utils/gpdr.js';
@@ -178,7 +178,7 @@ export const spec = {
 
 registerBidder(spec);
 
-const storage = getStorageManager({bidderCode: BIDDER_CODE});
+export const storage = getStorageManager({bidderCode: BIDDER_CODE});
 
 /**
  * Check or generate a UID for the current user.
@@ -188,10 +188,24 @@ function getUid(bidderRequest) {
     return false;
   }
 
-  const CONCERT_UID_KEY = 'c_uid';
+  const sharedId = deepAccess(bidderRequest, 'userId._sharedid.id');
 
+  if (sharedId) {
+    return sharedId;
+  }
+
+  const LEGACY_CONCERT_UID_KEY = 'c_uid';
+  const CONCERT_UID_KEY = 'vmconcert_uid';
+
+  const legacyUid = storage.getDataFromLocalStorage(LEGACY_CONCERT_UID_KEY);
   let uid = storage.getDataFromLocalStorage(CONCERT_UID_KEY);
 
+  if (legacyUid) {
+    uid = legacyUid;
+    storage.setDataInLocalStorage(CONCERT_UID_KEY, uid);
+    storage.removeDataFromLocalStorage(LEGACY_CONCERT_UID_KEY);
+  }
+
   if (!uid) {
     uid = generateUUID();
     storage.setDataInLocalStorage(CONCERT_UID_KEY, uid);

diff --git a/test/spec/modules/concertBidAdapter_spec.js b/test/spec/modules/concertBidAdapter_spec.js
@@ -1,7 +1,7 @@
 import { expect } from 'chai';
 import sinon from 'sinon';
-import { spec } from 'modules/concertBidAdapter.js';
-import { getStorageManager } from '../../../src/storageManager.js'
+import { spec, storage } from 'modules/concertBidAdapter.js';
+import { hook } from 'src/hook.js';
 
 describe('ConcertAdapter', function () {
   let bidRequests;
@@ -10,9 +10,8 @@ describe('ConcertAdapter', function () {
   let element;
   let sandbox;
 
-  afterEach(function () {
-    $$PREBID_GLOBAL$$.bidderSettings = {};
-    sandbox.restore();
+  before(function () {
+    hook.ready();
   });
 
   beforeEach(function () {
@@ -39,6 +38,7 @@ describe('ConcertAdapter', function () {
         storageAllowed: true
       }
     };
+
     bidRequests = [
       {
         bidder: 'concert',
@@ -83,6 +83,11 @@ describe('ConcertAdapter', function () {
     sandbox.stub(document, 'getElementById').withArgs('desktop_leaderboard_variable').returns(element)
   });
 
+  afterEach(function () {
+    $$PREBID_GLOBAL$$.bidderSettings = {};
+    sandbox.restore();
+  });
+
   describe('spec.isBidRequestValid', function() {
     it('should return when it recieved all the required params', function() {
       const bid = bidRequests[0];
@@ -118,7 +123,6 @@ describe('ConcertAdapter', function () {
     });
 
     it('should not generate uid if the user has opted out', function() {
-      const storage = getStorageManager();
       storage.setDataInLocalStorage('c_nap', 'true');
       const request = spec.buildRequests(bidRequests, bidRequest);
       const payload = JSON.parse(request.data);
@@ -127,17 +131,29 @@ describe('ConcertAdapter', function () {
     });
 
     it('should generate uid if the user has not opted out', function() {
-      const storage = getStorageManager();
       storage.removeDataFromLocalStorage('c_nap');
       const request = spec.buildRequests(bidRequests, bidRequest);
       const payload = JSON.parse(request.data);
 
       expect(payload.meta.uid).to.not.equal(false);
     });
 
-    it('should grab uid from local storage if it exists', function() {
-      const storage = getStorageManager();
-      storage.setDataInLocalStorage('c_uid', 'foo');
+    it('should use sharedid if it exists', function() {
+      storage.removeDataFromLocalStorage('c_nap');
+      const request = spec.buildRequests(bidRequests, {
+        ...bidRequest,
+        userId: {
+          _sharedid: {
+            id: '123abc'
+          }
+        }
+      });
+      const payload = JSON.parse(request.data);
+      expect(payload.meta.uid).to.equal('123abc');
+    })
+
+    it('should grab uid from local storage if it exists and sharedid does not', function() {
+      storage.setDataInLocalStorage('vmconcert_uid', 'foo');
       storage.removeDataFromLocalStorage('c_nap');
       const request = spec.buildRequests(bidRequests, bidRequest);
       const payload = JSON.parse(request.data);
@@ -211,7 +227,6 @@ describe('ConcertAdapter', function () {
       const opts = {
         iframeEnabled: true
       };
-      const storage = getStorageManager();
       storage.setDataInLocalStorage('c_nap', 'true');
 
       const sync = spec.getUserSyncs(opts, [], bidRequest.gdprConsent, bidRequest.uspConsent);
@@ -222,7 +237,6 @@ describe('ConcertAdapter', function () {
       const opts = {
         iframeEnabled: true
       };
-      const storage = getStorageManager();
       storage.removeDataFromLocalStorage('c_nap');
 
       bidRequest.gdprConsent = {
@@ -237,7 +251,6 @@ describe('ConcertAdapter', function () {
       const opts = {
         iframeEnabled: true
       };
-      const storage = getStorageManager();
       storage.removeDataFromLocalStorage('c_nap');
 
       bidRequest.gdprConsent = {
@@ -252,7 +265,6 @@ describe('ConcertAdapter', function () {
       const opts = {
         iframeEnabled: true
       };
-      const storage = getStorageManager();
       storage.removeDataFromLocalStorage('c_nap');
 
       bidRequest.gdprConsent = {
@@ -268,7 +280,6 @@ describe('ConcertAdapter', function () {
       const opts = {
         iframeEnabled: true
       };
-      const storage = getStorageManager();
       storage.removeDataFromLocalStorage('c_nap');
 
       bidRequest.gdprConsent = {