Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all Android methods from boolean to void #2

Closed
tripflex opened this issue Jan 8, 2018 · 1 comment
Closed

Convert all Android methods from boolean to void #2

tripflex opened this issue Jan 8, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@tripflex
Copy link
Owner

tripflex commented Jan 8, 2018

See #1 .. need to convert all Android Java methods to void instead of boolean since the only time they should be boolean is if we are actually expecting a boolean response.
@tripflex tripflex added the enhancement New feature or request label Jan 8, 2018
@tripflex
Copy link
Owner Author

tripflex commented Jan 8, 2018

May actually be better to just leave them as boolean but remove from exec returning that value (to allow actual results being returned in JS if needed later)

@tripflex tripflex closed this as completed Jan 8, 2018
tripflex added a commit that referenced this issue Jan 9, 2018
@tripflex
added async promise methods, added JS docs fixes #2
129b7f6
ViggoChavine referenced this issue in Effera/WifiWizard2 Oct 21, 2020
@VijayVaveHealth
Merge pull request #2 from VijayVaveHealth/vave
4137ed4 
Updated wifiwizard for vave connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tripflex