Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not find tables in information_schema in BigQuery #9908

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Nov 9, 2021

  • Run all BigQuery tests

@cla-bot cla-bot bot added the cla-signed label Nov 9, 2021
@ebyhr ebyhr requested a review from hashhar November 9, 2021 07:55
@ebyhr ebyhr merged commit 5cda4cd into trinodb:master Nov 9, 2021
@ebyhr ebyhr deleted the ebi/bigquery-skip-information-schema branch November 9, 2021 10:15
@github-actions github-actions bot added this to the 365 milestone Nov 9, 2021
@findepi
Copy link
Member

findepi commented Nov 9, 2021

Could there be a test for this? either in BQ or generic (since problem is generic: #1559)?

@ebyhr
Copy link
Member Author

ebyhr commented Nov 10, 2021

@findepi BigQuery's information_schema wasn't leaked and the purpose of this change is just skipping redundant logic. It took few seconds before this change:

trino> show tables in bigquery."information_schema";
             Table
--------------------------------
 applicable_roles
 columns
 enabled_roles
 role_authorization_descriptors
 roles
 schemata
 table_privileges
 tables
 views
(9 rows)

Query 20211109_003224_00000_ptrr6, FINISHED, 3 nodes
Splits: 17 total, 17 done (100.00%)
5.49 [9 rows, 358B] [1 rows/s, 65B/s]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants