Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acquire password in cli when its stdout is a pipe #982

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Acquire password in cli when its stdout is a pipe #982

merged 1 commit into from
Jun 18, 2019

Conversation

Praveen2112
Copy link
Member

Fixes #916

@cla-bot cla-bot bot added the cla-signed label Jun 13, 2019
electrum
electrum reviewed Jun 17, 2019
View reviewed changes
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits, otherwise looks good. Thanks for fixing this.

presto-cli/src/main/java/io/prestosql/cli/Console.java Outdated Show resolved Hide resolved
presto-cli/src/main/java/io/prestosql/cli/Console.java Outdated Show resolved Hide resolved
presto-cli/src/main/java/io/prestosql/cli/Console.java Outdated Show resolved Hide resolved
presto-cli/src/main/java/io/prestosql/cli/Console.java Outdated Show resolved Hide resolved
@Praveen2112
Copy link
Member Author

@electrum Thanks for your insights. Have applied your comments.

@electrum electrum added this to the 316 milestone Jun 18, 2019
@electrum electrum merged commit 77ec764 into trinodb:master Jun 18, 2019
@electrum electrum mentioned this pull request Jul 8, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrum electrum electrum approved these changes

Assignees

@electrum electrum

Labels
cla-signed
Milestone
316
Development

Successfully merging this pull request may close these issues.

presto-cli should acquire password using stdin&stderr when stdout is a pipe
2 participants
@Praveen2112 @electrum