Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when DELETE ACID block is a DictionaryBlock #9354

Closed
wants to merge 2 commits into from
Closed

Fix bug when DELETE ACID block is a DictionaryBlock #9354

wants to merge 2 commits into from

Commits on Sep 25, 2021

  1. Fix bug when DELETE ACID block is a DictionaryBlock 

    Before this commit, Block.getChildren() was used to take apart the
DELETE ACID rowId block.  That is always the wrong thing to do.
Fixed by using ColumnarRow to access the elementa of the ACID rowId block.

This commit also adds a comment warning developers not to use
Block.getChildren() so others don't make the same mistake of
calling the method.
    @djsstarburst
    djsstarburst committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    4d85258 View commit details
    Browse the repository at this point in the history

  2. Eliminate Block.getChildren() in Hive UPDATE 

    Replace use of Block.getChildren in HiveUpdatablePageSource and
HiveUpdateProcessor with ColumnarRow methods.
    @djsstarburst
    djsstarburst committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    a1d14f6 View commit details
    Browse the repository at this point in the history