-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQL support section to BigQuery connector #8923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Aug 20, 2021
ebyhr
reviewed
Aug 20, 2021
Jessie212
force-pushed
the
bigquery-sql-support
branch
from
August 20, 2021 14:54
19be23c
to
2b44414
Compare
ebyhr
approved these changes
Aug 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for a minor comment.
Jessie212
force-pushed
the
bigquery-sql-support
branch
from
August 20, 2021 17:10
2b44414
to
19809a0
Compare
jhlodin
reviewed
Aug 20, 2021
jhlodin
approved these changes
Aug 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment
Jessie212
force-pushed
the
bigquery-sql-support
branch
from
August 20, 2021 17:22
19809a0
to
795357f
Compare
ebyhr
reviewed
Aug 21, 2021
Jessie212
force-pushed
the
bigquery-sql-support
branch
from
August 23, 2021 14:18
795357f
to
573d32a
Compare
hashhar
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.