Fix handling of inserting into non-bucketed ACID tables #8899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashhar
reviewed
Aug 17, 2021
...rino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveTransactionalTable.java
Show resolved
Hide resolved
| @@ -2517,7 +2517,8 @@ else if (hasNaN) { | |||
| } | |||
| } | |||
| // treat un-bucketed transactional table as having a single bucket on no columns | |||
| else if (hiveTableHandle.isInAcidTransaction()) { | |||
| // Note: we cannot use hiveTableHandle.isInAcidTransaction() here as transaction is not yet set in HiveTableHandle when getInsertLayout is called | |||
There was a problem hiding this comment.
I'm not sure I understand this?
I can see that we do set the transaction in the HiveInsertTableHandle in beginInsert.
Is it because the engine calls getInsertLayout during planning (i.e. before execution when beginInsert would be called?)?
There was a problem hiding this comment.
The only other existing use I can see of the method is in
which seems to be okay.There was a problem hiding this comment.
Is it because the engine calls getInsertLayout during planning (i.e. before execution when beginInsert would be called?)?
Yeah - exactly. We are operating on TableHandle which is obtained by HiveMetadata.getTableHandle here. And the transaction field is set to NO_ACID_TRANSACTION there.
hashhar
approved these changes
Aug 18, 2021
This was referenced Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.