Fix assertions for old Hive versions in TestHiveViews for from_utc_timestamp

[losipiuk]

No description provided.

[losipiuk]

@hashhar @findepi - can we do better? :/

[hashhar]

Looks like the best we can do. It's better to document such things as tests rather than leave them unknown.

What is the Hive behaviour though - I can't understand how it's arriving at those specific values?

LGTM % nits.

[hashhar]

nit: Should we update the comment to be statement instead of a guess once the tests are green with this assumption.

[hashhar]

Also, maybe reversing the function logic (i.e. return !(condition)) + rename to isOld may make more sense given that the old behaviour is the "exceptional" behaviour and new behaviour is the expected one.

[losipiuk]

I reveresed the condition. As for guessing, the green pass does not tell us much. I see that behaviour is different for 3.1 and for older ones. But I do not know if the behavior switch was exactly on version 3.1

[losipiuk]

What is the Hive behaviour though - I can't understand how it's arriving at those specific values?

It looks like on old Hive values are shifted by timezone offset of Hive's VM. It is using Asia/Kathmandu which is +5:30 or 5:45 vs UTC.
I do not get what it did with 1811-07-23 07:13:41.999 which is 1811-07-23 12:51:39.999 on old Hive.