Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect results for aggregation functions on case-sensitive types #8551

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Fix incorrect results for aggregation functions on case-sensitive types #8551

merged 2 commits into from
Aug 2, 2021

Commits on Aug 2, 2021

  1. Provide more information to connectors to control aggregation pushdown

    @hashhar
    hashhar committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    c0bb821 View commit details
    Browse the repository at this point in the history

  2. Prevent aggregation pushdown for textual types for some connectors 

    Some databases are case-insensitive (MySQL, SQL Server) while others
sort textual types differently compared to Trino (PostgreSQL). For such
databases pushdown of aggregation functions when the grouping set
includes a textual type can lead to incorrect results. So we prevent
aggregation pushdown for such cases.
We also prevent pushdown for functions whose results depend on sort
order (min/max) when the input is a textual type.
    @hashhar
    hashhar committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    6473c84 View commit details
    Browse the repository at this point in the history