Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 359 release notes #8420

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Add 359 release notes #8420

merged 1 commit into from
Jul 2, 2021

Conversation

martint
Copy link
Member

@martint martint commented Jun 29, 2021

Closes #8170

@martint martint added this to the 359 milestone Jun 29, 2021
@cla-bot cla-bot bot added the cla-signed label Jun 29, 2021
docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-359.md Show resolved Hide resolved
docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved
@mosabua mosabua added the docs label Jun 29, 2021
docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved

## Security

* Fix user mapping for password authentication. Formerly, user mapping for password authentication
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could drop the whole sentence starting with "Formerly.." imho

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like the sentence to describe what was fixed, though. Without the second part, it's too vague. Maybe something like:

Fix spurious impersonation check when applying user mapping for password authentication.

docs/src/main/sphinx/release/release-359.md Show resolved Hide resolved
docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved
* Add support for granting `UPDATE` privileges when `hive.security=sql-standard` is used. ({issue}`8279`)
* Add support for inserting data into CSV and TEXT tables with skip_header_line_count table property set to 1.
The same applies to creating tables with data using `CREATE TABLE ... AS SELECT` syntax. ({issue}`8390`)
* Add validation so creating CSV and TEXT tables with data is not allowed if `skip_header_line_count` is set to a value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the PR tests (1) should we also include skip_footer_line_count (2) the condition should be > 0?

We can also change the statement to: Disallow creating CSV and TEXT tables with data if ....

cc @losipiuk

docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good % RNs from Dain and David.

docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-359.md Outdated Show resolved Hide resolved
@martint martint merged commit de922fd into trinodb:master Jul 2, 2021
@martint martint deleted the relnotes branch July 2, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Release notes for 359
5 participants