Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record output column datatype in EventListener #8405

Merged

Conversation

Praveen2112
Copy link
Member

No description provided.

Copy link
Contributor

@ksobolew ksobolew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough; but I'd like to see in a commit description what's the purpose of the extra information and what it would be used for

Now same column datatypes would be maintained during create/inserts
@Praveen2112 Praveen2112 force-pushed the praveen/051/types_column_metadata branch from fdc49d2 to 0b8a478 Compare June 28, 2021 15:37
@Praveen2112 Praveen2112 force-pushed the praveen/051/types_column_metadata branch from 0b8a478 to e5cc4d3 Compare June 28, 2021 15:38
@Praveen2112
Copy link
Member Author

@ksobolew , @kokosing AC

@Praveen2112 Praveen2112 merged commit 3abd8e3 into trinodb:master Jun 29, 2021
@Praveen2112 Praveen2112 mentioned this pull request Jun 29, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants