Validate ordinal based grouping expressions during analysis #8247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Jun 9, 2021
core/trino-main/src/test/java/io/trino/sql/analyzer/TestAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/analyzer/TestAnalyzer.java
Outdated
Show resolved
Hide resolved
phd3
force-pushed
the
ordinal-groupby-validate
branch
from
68a2716
to
6377c59
Compare
phd3
force-pushed
the
ordinal-groupby-validate
branch
from
6377c59
to
7303bf3
Compare
|
Merged #8247 into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries with GROUP BY ordinals mapping to aggregate expressions pass analysis and fail during
ScanFilterProject.(First of the two tests added also succeeds without the change.)