Rename isTopNLimitGuaranteed to isTopNGuaranteed #8238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous name could be interpreted as "is the limit component of TopN guaranteed, without regard to final results' ordering". The new name is aimed to be better and also comes with a javadoc.
raunaqmorarka
approved these changes
Jun 9, 2021
hashhar
approved these changes
Jun 9, 2021
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/DefaultJdbcMetadata.java
Show resolved
Hide resolved
findepi
deleted the
findepi/rename-istopnlimitguaranteed-to-istopnguaranteed-d3bdbd
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous name could be interpreted as "is the limit component of TopN
guaranteed, without regard to final results' ordering". The new name
is aimed to be better and also comes with a javadoc.
cc @kokosing @hashhar @lhofhansl