Enable connector to perform materialized view refresh itself #7960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
force-pushed
the
ks/refresh_delegate_to_connector
branch
from
89e229e
to
d0e5e2e
Compare
martint
reviewed
May 24, 2021
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMaterializedViewDefinition.java
Outdated
Show resolved
Hide resolved
sopel39
force-pushed
the
ks/refresh_delegate_to_connector
branch
from
d0e5e2e
to
4059464
Compare
sopel39
force-pushed
the
ks/refresh_delegate_to_connector
branch
from
4059464
to
3a88c9c
Compare
|
ping @martint |
martint
reviewed
Jun 2, 2021
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMaterializedViewDefinition.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/RefreshMaterializedViewOperator.java
Show resolved
Hide resolved
sopel39
force-pushed
the
ks/refresh_delegate_to_connector
branch
from
3a88c9c
to
21884d5
Compare
sopel39
force-pushed
the
ks/refresh_delegate_to_connector
branch
2 times, most recently
from
06bfbfe
to
996d432
Compare
martint
approved these changes
Jun 7, 2021
Introduce ConnectorMetadata#refreshMaterializedView that will be called when materialized view refresh is delegated to connector.
sopel39
force-pushed
the
ks/refresh_delegate_to_connector
branch
from
996d432
to
0485780
Compare
| @Override | ||
| public boolean delegateMaterializedViewRefreshToConnector(ConnectorSession session, SchemaTableName viewName) | ||
| { | ||
| throw new TrinoException(NOT_SUPPORTED, "This connector does not support dropping materialized views"); |
There was a problem hiding this comment.
nit: should be This connector does not support materialized views in both methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce ConnectorMetadata#refreshMaterializedView that will
be called when materialized view refresh is delegated to connector.