Improve conversion to domain #7754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example when providing values to a `BIGINT`-based `ValueSet`, one should be able to pass a `List<Long>` as values.
This comment has been minimized.
This comment has been minimized.
|
CI #7755 |
skrzypo987
reviewed
Apr 27, 2021
| @@ -308,56 +308,51 @@ public static Domain getDomain(Type type, DictionaryDescriptor dictionaryDescrip | |||
|
|
|||
| int dictionarySize = dictionaryPage.get().getDictionarySize(); | |||
| if (type.equals(BIGINT) && columnDescriptor.getPrimitiveType().getPrimitiveTypeName() == PrimitiveTypeName.INT64) { | |||
| List<Domain> domains = new ArrayList<>(); | |||
| List<Long> values = new ArrayList<>(); | |||
There was a problem hiding this comment.
If this is the bottleneck then maybe long[] will be faster.
There was a problem hiding this comment.
ValueSet constructor currently does accept primitive arrays.
however, i will at least preallocate the list to the required size, since it's well known.
losipiuk
approved these changes
Apr 27, 2021
This fixes a performance regression introduced by 82e8f93.
findepi
force-pushed
the
findepi/parpred
branch
from
5938bab
to
baeef04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.