Add checkCanRefreshMaterializedView access control #7707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
approved these changes
Apr 22, 2021
...trino-plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControl.java
Outdated
Show resolved
Hide resolved
kokosing
reviewed
Apr 23, 2021
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Show resolved
Hide resolved
...trino-plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControl.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
mv-refresh-ac
branch
from
525ec47
to
73b7103
Compare
raunaqmorarka
force-pushed
the
mv-refresh-ac
branch
from
73b7103
to
12fa1a8
Compare
kokosing
approved these changes
Apr 23, 2021
| @@ -11,7 +11,7 @@ | |||
| }, | |||
| { | |||
| "user": "admin", | |||
| "privileges": ["SELECT", "INSERT", "DELETE", "OWNERSHIP"] | |||
| "privileges": ["SELECT", "INSERT", "UPDATE", "DELETE", "OWNERSHIP"] | |||
There was a problem hiding this comment.
Why do we need to add "UPDATE" if user already has "OWNERSHIP"?
There was a problem hiding this comment.
FileBasedAccessControl#checkTablePermission doesn't give any special importance to OWNERSHIP privilege, it checks for the presence of specified privilege only.
raunaqmorarka
force-pushed
the
mv-refresh-ac
branch
from
12fa1a8
to
33b942b
Compare
sopel39
reviewed
Apr 26, 2021
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
mv-refresh-ac
branch
from
33b942b
to
388ff38
Compare
sopel39
approved these changes
Apr 27, 2021
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
mv-refresh-ac
branch
from
388ff38
to
39b558c
Compare
|
Doesnt this need some sort of documentation? At least an example? |
|
If we have no section on materialized views .. we should add one. |
anjalinorwood
approved these changes
Apr 28, 2021
raunaqmorarka
force-pushed
the
mv-refresh-ac
branch
from
39b558c
to
5f78cd6
Compare
Apply access control check on materialzed view object instead of the storage table for REFRESH MV command.
raunaqmorarka
force-pushed
the
mv-refresh-ac
branch
from
5f78cd6
to
c9468d6
Compare
@mosabua could you craete issue for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.