Add operator cache and coercion cache to reduce planning time #7556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
reviewed
Apr 13, 2021
core/trino-main/src/test/java/io/trino/sql/planner/BenchmarkPlanner.java
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Apr 13, 2021
|
I think @dain has some pending changes related to this in the work he’s been doing around function system revamp |
sopel39
approved these changes
Apr 15, 2021
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
MetadataManager.resolveOperator() and MetadataManager.getCoercion() are frequently invoked during planning. Add cache for them could reduce many planning time for IN predicate with a large list. before the change Benchmark (stage) Mode Cnt Score Error Units BenchmarkPlanner.planLargeInQuery optimized avgt 20 17808.872 ± 326.616 ms/op BenchmarkPlanner.planLargeInQuery created avgt 20 52.415 ± 2.171 ms/op After the change Benchmark (stage) Mode Cnt Score Error Units BenchmarkPlanner.planLargeInQuery optimized avgt 20 5110.045 ± 88.355 ms/op BenchmarkPlanner.planLargeInQuery created avgt 20 50.761 ± 1.200 ms/op
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetadataManager.resolveOperator() and MetadataManager.getCoercion() are frequently invoked during planning.
Add cache for them could reduce many planning time for IN predicate with a large list.
before the change
Benchmark (stage) Mode Cnt Score Error Units
BenchmarkPlanner.planLargeInQuery optimized avgt 20 17808.872 ± 326.616 ms/op
BenchmarkPlanner.planLargeInQuery created avgt 20 52.415 ± 2.171 ms/op
After the change
Benchmark (stage) Mode Cnt Score Error Units
BenchmarkPlanner.planLargeInQuery optimized avgt 20 5110.045 ± 88.355 ms/op
BenchmarkPlanner.planLargeInQuery created avgt 20 50.761 ± 1.200 ms/op