Fix case sensitivity issue of MongoDB view #7546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
mongodb-view-case-sensitivity
branch
from
085a9e8
to
d02cc4f
Compare
findepi
approved these changes
Apr 19, 2021
| @@ -432,7 +433,7 @@ private Document getTableMetadata(SchemaTableName schemaTableName) | |||
|
|
|||
| if (doc == null) { | |||
| if (!collectionExists(db, tableName)) { | |||
| throw new TableNotFoundException(schemaTableName); | |||
| throw new TableNotFoundException(new SchemaTableName(schemaName, tableName)); | |||
There was a problem hiding this comment.
This will lowercase schemaName, tableName. Let's pass actual names (case-preserving) with some String message message
findepi
reviewed
Apr 19, 2021
| @@ -325,6 +325,34 @@ public void testCaseInsensitive() | |||
| assertUpdate("DROP TABLE testcase.testinsensitive"); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testCaseInsensitiveView() | |||
| public void testCaseInsensitiveView() | ||
| { | ||
| // Case insensitive schema name | ||
| MongoCollection<Document> collection = client.getDatabase("testInsensitive").getCollection("test_collection"); |
There was a problem hiding this comment.
testInsensitive -> eg NonLowercaseSchema
| MongoCollection<Document> collection = client.getDatabase("testInsensitive").getCollection("test_collection"); | ||
| collection.insertOne(new Document(ImmutableMap.of("Name", "abc", "Value", 1))); | ||
|
|
||
| client.getDatabase("testInsensitive").createView("test_view", "test_collection", ImmutableList.of()); |
| collection = client.getDatabase("test_database").getCollection("test_collection"); | ||
| collection.insertOne(new Document(ImmutableMap.of("Name", "abc", "Value", 1))); | ||
|
|
||
| client.getDatabase("test_database").createView("testInsensitive", "test_collection", ImmutableList.of()); |
There was a problem hiding this comment.
testInsensitive -> eg NonLowercaseView
ebyhr
force-pushed
the
mongodb-view-case-sensitivity
branch
from
d02cc4f
to
08a9a76
Compare
hashhar
approved these changes
Apr 24, 2021
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoIntegrationSmokeTest.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
mongodb-view-case-sensitivity
branch
from
08a9a76
to
8280f46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7491