Simplify SQL Server limit function #6676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some databases require columns to be named under some conditions. For example, SQL Servers require this in subqueries.
Remove editing of the query, by putting the original query in a subquery.
Praveen2112
reviewed
Jan 21, 2021
| checkArgument(sql.startsWith(start)); | ||
| return "SELECT TOP " + limit + " " + sql.substring(start.length()); | ||
| }); | ||
| return Optional.of((sql, limit) -> format("SELECT TOP %s * FROM (%s) o", limit, sql)); |
There was a problem hiding this comment.
nit : Since limit is a long , so can we provide proper format specifier for the same ?
There was a problem hiding this comment.
i use (we use?) %s for simplicity, unless i want to have type-specific formatting.
|
CI #6646 |
losipiuk
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #6667, for #6620