Allow using legacy Hive view translation logic #6195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
commented
Dec 3, 2020
| @@ -38,7 +38,7 @@ | |||
| ImmutableNationTable.class, | |||
| ImmutableOrdersTable.class, | |||
| }) | |||
| public class TestHiveViews | |||
| public abstract class BaseTestHiveViews | |||
There was a problem hiding this comment.
I am not super convinced that we need this base class.
Maybe just leave TestHiveViews as is, and use it for testing default configuration (with Coral).
And add TestHiveViewsLegacy based on how TestHiveViews looked before Coral was introduced.
losipiuk
force-pushed
the
lo/allow-old-hive-view-translation
branch
from
4a616eb
to
05822c4
Compare
findepi
approved these changes
Dec 3, 2020
presto-hive/src/main/java/io/prestosql/plugin/hive/ViewReaderUtil.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test(groups = HIVE_VIEWS) | ||
| public void testShowCreateView() |
There was a problem hiding this comment.
Did you mean to inherit these tests from the base class?
There was a problem hiding this comment.
Those are slightly differnt actually.
On the second though I decided to just have separate test classes and drop common base.
losipiuk
force-pushed
the
lo/allow-old-hive-view-translation
branch
from
05822c4
to
1883af4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.