Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MetastoreConfig to MetastoreTypeConfig #5437

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Rename MetastoreConfig to MetastoreTypeConfig #5437

merged 1 commit into from
Oct 7, 2020

Conversation

findepi
Copy link
Member

@findepi findepi commented Oct 6, 2020

Per #5430 (comment) preparation to #5430

@cla-bot cla-bot bot added the cla-signed label Oct 6, 2020
@phd3
Copy link
Member

phd3 commented Oct 6, 2020 •
edited
Loading

@findepi I was thinking we could use enum for metastore type. I've created a separate PR #5439 (need to rebase after this goes in). What do you think?

@findepi findepi merged commit caf6c36 into trinodb:master Oct 7, 2020
@findepi findepi deleted the findepi/rename-metastoreconfig-to-metastoretypeconfig-378a5f branch October 7, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phd3 phd3 phd3 approved these changes

@losipiuk losipiuk losipiuk approved these changes

@electrum electrum Awaiting requested review from electrum

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@findepi @phd3 @losipiuk