Fix potential deadlock when HttpPageBufferClient exceeds memory limit #5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
reviewed
Sep 25, 2020
presto-main/src/main/java/io/prestosql/operator/HttpPageBufferClient.java
Show resolved
Hide resolved
Prior to this change, if the HttpPageBufferClient caused a task to exceed its memory limit inside of addPages, the exception would bubble to the root of the exchange client callback executor without ever marking the task as failed. If no other operator also saw the memory limit exceeded condition, then the task would become stuck in a deadlocked state.
pettyjamesm
force-pushed
the
handle-exchange-client-memory-limit-exception
branch
from
5a34728
to
22f06fa
Compare
sopel39
approved these changes
Sep 28, 2020
| @@ -237,7 +244,7 @@ public void testInvalidResponses() | |||
| "localhost", | |||
| new TestingHttpClient(processor, scheduler), | |||
| DataIntegrityVerification.ABORT, | |||
| DataSize.of(10, Unit.MEGABYTE), | |||
There was a problem hiding this comment.
nit: this could be separate commit
|
merged, thanks! |
pettyjamesm
deleted the
handle-exchange-client-memory-limit-exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparable changes to prestodb/presto#15220
Prior to this change, if the HttpPageBufferClient caused a task to exceed its memory limit inside of addPages, the exception would bubble to the root of the exchange client callback executor without ever marking the task as failed. If no other operator also saw the memory limit exceeded condition, then the task would become stuck in a deadlocked
state.