Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push dynamic filters into DynamicFilterService #5081

Merged
merged 6 commits into from
Sep 28, 2020
Merged

Push dynamic filters into DynamicFilterService #5081

merged 6 commits into from
Sep 28, 2020

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Sep 4, 2020

Depends on: #4988

@sopel39 sopel39 added the WIP label Sep 4, 2020
@cla-bot cla-bot bot added the cla-signed label Sep 4, 2020
@sopel39 sopel39 removed the WIP label Sep 4, 2020
@sopel39 sopel39 force-pushed the ks/dynamic_filters_push branch 3 times, most recently from 8b4e9fb to 9daa15c Compare September 7, 2020 13:49
@sopel39 sopel39 requested a review from martint September 8, 2020 15:57
@sopel39 sopel39 force-pushed the ks/dynamic_filters_push branch 3 times, most recently from 449e70d to e7fe691 Compare September 14, 2020 15:47
@sopel39 sopel39 requested a review from dain September 14, 2020 20:23
@sopel39
Copy link
Member Author

sopel39 commented Sep 16, 2020

rebased

@sopel39 sopel39 force-pushed the ks/dynamic_filters_push branch 3 times, most recently from d97d1a5 to 796b52b Compare September 17, 2020 14:16
@sopel39 sopel39 mentioned this pull request Sep 17, 2020
Closed
dain
dain reviewed Sep 18, 2020
View reviewed changes
Copy link
Member

@dain dain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions about concurrency, but the high level looks good. I don't think I understand DynamicFilterService enough to review those bits. Hopefully, @martint can handle those.

presto-main/src/main/java/io/prestosql/server/remotetask/DynamicFiltersFetcher.java Show resolved Hide resolved
presto-main/src/test/java/io/prestosql/server/TestDynamicFilterService.java Outdated Show resolved Hide resolved
presto-main/src/test/java/io/prestosql/server/TestDynamicFilterService.java Outdated Show resolved Hide resolved
presto-main/src/test/java/io/prestosql/server/TestDynamicFilterService.java Show resolved Hide resolved
presto-main/src/main/java/io/prestosql/server/DynamicFilterService.java Show resolved Hide resolved
presto-main/src/main/java/io/prestosql/server/DynamicFilterService.java Outdated Show resolved Hide resolved
presto-main/src/main/java/io/prestosql/sql/analyzer/FeaturesConfig.java Outdated Show resolved Hide resolved
presto-main/src/main/java/io/prestosql/server/DynamicFilterService.java Outdated Show resolved Hide resolved
presto-main/src/main/java/io/prestosql/server/DynamicFilterService.java Show resolved Hide resolved
@sopel39 sopel39 force-pushed the ks/dynamic_filters_push branch 2 times, most recently from 360a053 to 03a4975 Compare September 21, 2020 12:57
sopel39
sopel39 commented Sep 21, 2020
View reviewed changes
Copy link
Member Author

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ac @dain

presto-main/src/main/java/io/prestosql/server/remotetask/DynamicFiltersFetcher.java Show resolved Hide resolved
presto-main/src/main/java/io/prestosql/server/DynamicFilterService.java Show resolved Hide resolved
@sopel39 sopel39 requested a review from dain September 21, 2020 12:57
@sopel39 sopel39 force-pushed the ks/dynamic_filters_push branch 3 times, most recently from d899db2 to 601d42a Compare September 25, 2020 10:03
@sopel39
Copy link
Member Author

sopel39 commented Sep 25, 2020

rebased

@sopel39 sopel39 merged commit e5234fa into trinodb:master Sep 28, 2020
@sopel39 sopel39 deleted the ks/dynamic_filters_push branch September 28, 2020 09:30
@sopel39 sopel39 mentioned this pull request Sep 28, 2020
Closed
10 tasks
@martint martint added this to the 344 milestone Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohangarg rohangarg rohangarg left review comments

@martint martint martint approved these changes

@dain dain Awaiting requested review from dain

Assignees
No one assigned
Labels
cla-signed
Milestone
344
Development

Successfully merging this pull request may close these issues.
4 participants
@sopel39 @martint @dain @rohangarg