Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup file access control #5039

Merged
merged 20 commits into from
Oct 7, 2020
Merged

Cleanup file access control #5039

merged 20 commits into from
Oct 7, 2020
+1,863 −364

Commits on Oct 7, 2020

  1. Simplify FileBasedAccessControl

    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    334fc3d View commit details
    Browse the repository at this point in the history

  2. Fix warnings in FileBasedSystemAccessControl

    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    6611817 View commit details
    Browse the repository at this point in the history

  3. Change catalog check to match other checks 

    Place check catalog method near other checks
    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    e10a04b View commit details
    Browse the repository at this point in the history

  4. Simplify catalog checks in FileBasedSystemAccessControl

    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    06b1afc View commit details
    Browse the repository at this point in the history

  5. Simplify query checks in FileBasedSystemAccessControl

    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    9e4dc78 View commit details
    Browse the repository at this point in the history

  6. Clean up exception messages in FileBasedSystemAccessControl

    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    4f846b2 View commit details
    Browse the repository at this point in the history

  7. Change file access control to consistently use snake case 

    Old camel case names are still supported
    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    1c65efa View commit details
    Browse the repository at this point in the history

  8. Fix file access control for table create and rename checks 

    Changed file based access control to check for table ownership to create,
rename, or drop tables or views.
    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    162f3fe View commit details
    Browse the repository at this point in the history

  9. Fix system file create schema check

    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    a5a0325 View commit details
    Browse the repository at this point in the history

  10. Add missing table checks in file system access control

    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    78f61cd View commit details
    Browse the repository at this point in the history

  11. Filter tables in file access control 

    Only show tables the user has permissions on
    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    4b83065 View commit details
    Browse the repository at this point in the history

  12. Add catalog regex to schema and table rules in file system access con… 

    …trol
    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    cf812ba View commit details
    Browse the repository at this point in the history

  13. Allow all catalog access by default in file-based access control 

    If no catalog rules are defined, allow all catalog access
    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    41aa1f9 View commit details
    Browse the repository at this point in the history

  14. Simplify table and schema rules in file system access control 

    Table and schema default to allow if there are no rules defined, so replace
Optional empty with an allow allow rule
    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    a65adc6 View commit details
    Browse the repository at this point in the history

  15. Change catalog file access default to allow for no rules 

    System access control defaults to allow if no rules are defined for table,
schema, and session property
    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    4c24f4f View commit details
    Browse the repository at this point in the history

  16. Only show catalog if user has schema or table permissions

    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    6039d26 View commit details
    Browse the repository at this point in the history

  17. Only show schema if user is schema owner or has table permissions

    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    a94a921 View commit details
    Browse the repository at this point in the history

  18. Deny grant and revoke for catalog file access control 

    Catalog file access control is static and not used in combination with other
access control systems, so grant and revoke are denied.
    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    7cc4a2b View commit details
    Browse the repository at this point in the history

  19. Add session property rules to system file access control

    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    b8da3dd View commit details
    Browse the repository at this point in the history

  20. Improve system file based access documentation

    @dain
    dain committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    a4bc95a View commit details
    Browse the repository at this point in the history