Implement variable-precision TIME WITH TIME ZONE #4905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
force-pushed
the
timetz-parametric
branch
12 times, most recently
from
f21202d
to
0670ff6
Compare
martint
changed the title
martint
force-pushed
the
timetz-parametric
branch
2 times, most recently
from
6c05328
to
205ec48
Compare
dain
approved these changes
Sep 1, 2020
presto-jdbc/src/main/java/io/prestosql/jdbc/AbstractPrestoResultSet.java
Show resolved
Hide resolved
presto-jdbc/src/main/java/io/prestosql/jdbc/AbstractPrestoResultSet.java
Outdated
Show resolved
Hide resolved
...in/src/main/java/io/prestosql/operator/scalar/timestamp/TimestampToTimeWithTimezoneCast.java
Outdated
Show resolved
Hide resolved
...in/src/main/java/io/prestosql/operator/scalar/timestamp/TimestampToTimeWithTimezoneCast.java
Outdated
Show resolved
Hide resolved
...in/src/main/java/io/prestosql/operator/scalar/timestamp/TimestampToTimeWithTimezoneCast.java
Outdated
Show resolved
Hide resolved
presto-spi/src/main/java/io/prestosql/spi/type/ShortTimeWithTimeZoneType.java
Outdated
Show resolved
Hide resolved
presto-spi/src/main/java/io/prestosql/spi/type/ShortTimeWithTimeZoneType.java
Outdated
Show resolved
Hide resolved
|
|
||
| private final int precision; | ||
|
|
||
| public static TimeWithTimeZoneType createTimeWithTimeZoneType(int precision) |
There was a problem hiding this comment.
Update this to the same style in the other date time types.
presto-spi/src/main/java/io/prestosql/spi/type/TimeWithTimeZoneType.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Normalize to offset +00:00. The calculation is done modulo 24h | ||
| */ | ||
| static long normalize(long picos, int offsetMinutes) |
There was a problem hiding this comment.
we should consider having public "normalize" for short and long in the SPI
martint
force-pushed
the
timetz-parametric
branch
6 times, most recently
from
2eee5c3
to
7624a42
Compare
martint
force-pushed
the
timetz-parametric
branch
from
7624a42
to
9474616
Compare
findepi
reviewed
Nov 23, 2023
|
|
||
| long nanos = rescale(floorMod(epochMillis, MILLISECONDS_PER_DAY), 3, 9); | ||
|
|
||
| return packTimeWithTimeZone(nanos, DateTimes.getOffsetMinutes(Instant.ofEpochMilli(epochMillis), zoneKey)); |
There was a problem hiding this comment.
Should this use the zone object that we have above and thus avoid allocation of the Instant (and further allocations in the getOffsetMinutes method)?
perhaps this should get same offsetMinutes value:
getChronology(zoneKey).getZone().getOffset(epochMillis) / MILLISECONDS_PER_MINUTE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191, too.