Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to FileInputStream if PemReader fails to read certificates #4432

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Fallback to FileInputStream if PemReader fails to read certificates #4432

merged 1 commit into from
Aug 3, 2020

Conversation

yashaswaj
Copy link
Contributor

No description provided.

@cla-bot
Copy link

cla-bot bot commented Jul 13, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/prestosql/cla.

@cla-bot
Copy link

cla-bot bot commented Jul 13, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/prestosql/cla.

@cla-bot
Copy link

cla-bot bot commented Jul 13, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/prestosql/cla.

@findepi findepi requested a review from electrum July 16, 2020 19:57
@martint martint requested a review from dain July 22, 2020 02:49
@dain dain removed the request for review from electrum August 2, 2020 19:56
@cla-bot cla-bot bot added the cla-signed label Aug 3, 2020
@yashaswaj yashaswaj requested a review from dain August 3, 2020 09:53
@dain
Copy link
Member

dain commented Aug 3, 2020

BTW with the above changes applied, I think this is ready to go

dain
dain requested changes Aug 3, 2020
View reviewed changes
Copy link
Member

@dain dain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you missed dropping the new log field (and related imports).

...main/java/io/prestosql/plugin/hive/metastore/thrift/DefaultThriftMetastoreClientFactory.java Outdated
@@ -49,6 +52,7 @@
public class DefaultThriftMetastoreClientFactory
implements ThriftMetastoreClientFactory
{
private static final Logger log = Logger.get(DefaultThriftMetastoreClientFactory.class);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log field is no longer used

@dain dain merged commit 10a986b into trinodb:master Aug 3, 2020
@dain dain mentioned this pull request Aug 3, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lewuathe Lewuathe Lewuathe left review comments

@dain dain dain requested changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yashaswaj @dain @Lewuathe