-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hive 3 missing privileges and principal #4307
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/prestosql/cla. |
INDEX, | ||
LOCK, | ||
WRITE, | ||
GROUP, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is GROUP
privilege?
@@ -15,5 +15,5 @@ | |||
|
|||
public enum PrincipalType | |||
{ | |||
USER, ROLE | |||
USER, ROLE, GROUP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CREATE, | ||
DROP, | ||
INDEX, | ||
LOCK, | ||
WRITE, | ||
GROUP, | ||
READ, | ||
/**/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please squash commits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squashed. Thanks.
For the privileges that have no meaning in Presto, is there a point in defining them? Since we effectively ignore them, we could ignore them early, when mapping from thrift responses to Presto permissions model. |
User won't be able to grant them as it is only
If we hit that with properly configured (sql-standard?) access control then it means that we have a bug (aka missing feature) IMO. |
35f9cde
to
32a74d5
Compare
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/prestosql/cla. |
👋 @jiegzhan - this PR has become inactive. If you're still interested in working on it, please let us know, and we can try to get reviewers to help with that. We're working on closing out old and inactive PRs, so if you're too busy or this has too many merge conflicts to be worth picking back up, we'll be making another pass to close it out in a few weeks. |
I was testing kolosing's PR: #4254, then I encountered these errors below:
I made changes on top of kokosing's PR and tested with my hive-3-metastore-service (hadoop 3.2.1, hive 3.1.2), now I am able to run presto queries.
Please merge kokosing's PR first. This PR added extra privileges and principal on top of his PR. Thanks a lot. @electrum