Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate table layouts #420

Merged
merged 3 commits into from
Mar 11, 2019
Merged

Deprecate table layouts #420

merged 3 commits into from
Mar 11, 2019

Commits on Mar 11, 2019

  1. Remove unnecessary expression rewrite

    @martint
    martint committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    35dd636 View commit details
    Browse the repository at this point in the history

  2. Encapsulate expression type analysis in planner 

    The new class is to facilitate obtaining the type of an expression and its subexpressions
during planning (i.e., when interacting with IR expression) and to remove spurious
dependencies on the SQL parser. It will eventually get removed when we split the AST
from the IR and we encode the type directly into IR expressions.
    @martint
    martint committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    f04adeb View commit details
    Browse the repository at this point in the history

  3. Deprecate table layouts 

    Introduce a usesLegacyMetadata() method to ConnectorMetadata for
connectors to indicate if they use the legacy Table Layouts feature.
The method returns true by default during the transition period.

The following methods are deprecated:

    ConnectorMetadata.getTableLayouts()
    ConnectorMetadata.getTableLayout()
    ConnectorMetadata.getInfo(ConnectorTableLayoutHandle)
    ConnectorHandleResolver.getTableLayoutHandleClass()
    ConnectorSplitManager.getSplits(..., ConnectorTableLayoutHandle, ...)

Connectors that do not support Table Layouts need to implement
new methods instead:

    ConnectorMetadata.getTableProperties()
    ConnectorMetadata.getInto(ConnectorTableHandle)
    ConnectorSplitManager.getSplits(..., ConnectorTableHandle, ...)
    @martint
    martint committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    f4ce2a2 View commit details
    Browse the repository at this point in the history