Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Auth support for filter mask - replace table with inline view #348

Closed
wants to merge 1 commit into from
Closed

[WIP] Auth support for filter mask - replace table with inline view #348

wants to merge 1 commit into from

Conversation

raviann
Copy link
Member

@raviann raviann commented Feb 28, 2019 •
edited
Loading

This is preview PR towards discussion for #345

  • In this PR, RowFilterColumnMaskingRewrite is added which handles visitTable() to convert the table node into aliased relation (inline view)
  • SystemAccessControl has been extended to support applyTableInlineView()

This PR does not yet make AST rewrite pluggable.

References: prestodb/presto#11640

@raviann raviann changed the title [WIP] Auth support for filter mask - replace table with with inline view #345 [WIP] Auth support for filter mask - replace table with with inline view Feb 28, 2019
@raviann raviann changed the title [WIP] Auth support for filter mask - replace table with with inline view [WIP] Auth support for filter mask - replace table with inline view Feb 28, 2019
@kokosing kokosing added WIP and removed WIP labels May 8, 2019
@jiwenyu0531
Copy link

Hi @raviann ,
May I know when will this feature be merged?
Thanks a lot.

@raviann
Copy link
Member Author

raviann commented Jul 12, 2019

This PR is raised as sample implementation for #345
Closing this as #345 is included under #18

@raviann raviann closed this Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raviann @jiwenyu0531 @kokosing