Allow to set custom metastore in HiveQueryRunner #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Mar 5, 2020
| metastore.createDatabase(identity, createDatabaseMetastoreObject(TPCH_SCHEMA)); | ||
| copyTpchTables(queryRunner, "tpch", TINY_SCHEMA_NAME, createSession(Optional.empty()), tables); | ||
| } | ||
| public Builder setTables(Iterable<TpchTable<?>> tables) |
| .setExtraProperties(extraProperties) | ||
| .setBaseDataDir(baseDataDir) | ||
| .build(); | ||
| public Builder setExtraHiveProperties(Map<String, String> extraHiveProperties) |
There was a problem hiding this comment.
setHiveProperties? not sure why we had "extra" here
There was a problem hiding this comment.
Because there are some defaults. And it was named like this before.
| public static DistributedQueryRunner createQueryRunner(Iterable<TpchTable<?>> tables, Map<String, String> extraProperties, Optional<Path> baseDataDir) | ||
| throws Exception | ||
| public static class Builder | ||
| extends DistributedQueryRunner.Builder |
There was a problem hiding this comment.
since you inherit parent builder, you should pass your own Builder type there and the parent builder should return T from build methods... otherwise code using builder needs to use methods in certain specific order, not the way builder should work
follow-up maybe
There was a problem hiding this comment.
I was thinking about this. It looks like a follow-up
| Map<String, String> hiveProperties = ImmutableMap.<String, String>builder() | ||
| .put("hive.time-zone", TIME_ZONE.getID()) | ||
| .put("hive.max-partitions-per-scan", "1000") | ||
| .put("hive.assume-canonical-partition-keys", "true") |
There was a problem hiding this comment.
Why is this default?? TODO maybe
kokosing
force-pushed
the
origin/master/233_hive_query_runner_metastore
branch
from
b9ce77c
to
05cf6ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to set custom metastore in HiveQueryRunner