Add Salesforce JDBC Connector #2548

pgagnon · 2020-01-18T16:34:55Z

Closes #1854

martint · 2020-02-19T18:58:24Z

@Praveen2112, can you help review this?

Praveen2112 · 2020-02-21T18:12:48Z

@martint Yes

Praveen2112

Thanks for working on this.

presto-salesforce/src/main/java/io/prestosql/plugin/salesforce/SalesforceClientModule.java

presto-salesforce/src/main/java/io/prestosql/plugin/salesforce/SalesforceClient.java

Praveen2112 · 2020-02-21T18:45:31Z

presto-salesforce/src/main/java/io/prestosql/plugin/salesforce/SalesforceClient.java

+    private static BlockWriteFunction multiPicklistWriteFunction(Type type)
+    {
+        return (statement, index, value) -> {
+            // Not implemented


Any reasons for not implementing it ? It would be iterating over that value and building a string ?

Pure laziness at this point; the JDBC driver does not support writes yet.

...-salesforce/src/main/java/io/prestosql/plugin/salesforce/driver/soap/ForceSoapValidator.java

presto-salesforce/src/main/java/io/prestosql/plugin/salesforce/driver/statement/FieldDef.java

...rce/src/main/java/io/prestosql/plugin/salesforce/driver/statement/ParameterMetadataImpl.java

...lesforce/src/main/java/io/prestosql/plugin/salesforce/driver/connection/ForceConnection.java

Praveen2112 · 2020-02-23T09:17:29Z

...lesforce/src/main/java/io/prestosql/plugin/salesforce/driver/connection/ForceConnection.java

+            metadataCache.put(this.partnerConnection.getConfig().getUsername(), this.metadata);
+        }
+
+        this.metadata.setConnection(this);


But it won't be thread safe right ?

...lesforce/src/main/java/io/prestosql/plugin/salesforce/driver/connection/ForceConnection.java

martint · 2020-09-28T16:14:49Z

presto-salesforce/pom.xml

+        <repository>
+            <id>mulesoft-releases</id>
+            <name>MuleSoft Releases Repository</name>
+            <url>http://repository.mulesoft.org/releases/</url>
+            <layout>default</layout>
+        </repository>


Are the artifacts in maven central? It's not a good idea to depend on third-party repositories. It makes the build more brittle and makes it hard for people that are using a maven proxy in their organizations.

Good point. Let me check on that.

…sforce connector

…lugins list

…ions

Praveen2112 · 2020-10-02T12:54:36Z

presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/BaseJdbcClient.java

@@ -941,7 +941,6 @@ private static String escapeNamePattern(String name, String escape)
    {
        requireNonNull(name, "name is null");
        requireNonNull(escape, "escape is null");
-        checkArgument(!escape.isEmpty(), "Escape string must not be empty");


Can we implement it as a separate commit

Praveen2112 · 2020-10-02T12:55:56Z

presto-salesforce/src/main/java/io/prestosql/plugin/salesforce/SalesforceClient.java

+    public SalesforceClient(BaseJdbcConfig baseConfig, SalesforceConfig salesforceConfig, ConnectionFactory connectionFactory)
+    {
+        super(baseConfig, "", connectionFactory);
+


This line can be removed

Praveen2112 · 2020-10-02T12:57:46Z

...rce/src/test/java/io/prestosql/plugin/salesforce/driver/statement/SoqlQueryAnalyzerTest.java

+import java.util.List;
+import java.util.stream.Collectors;
+
+import static org.junit.Assert.assertEquals;


We can also use TestNG right ?

Praveen2112 · 2020-10-02T13:02:54Z

presto-salesforce/src/main/java/io/prestosql/plugin/salesforce/SalesforceClientModule.java

+                .to(SalesforceClient.class)
+                .in(Scopes.SINGLETON);
+
+        configBinder(binder).bindConfig(BaseJdbcConfig.class);


It would be binded in BaseJdbcModules so I guess we might not have to bind here

Praveen2112 · 2020-10-02T13:03:02Z

presto-salesforce/src/main/java/io/prestosql/plugin/salesforce/SalesforceClientModule.java

+                .in(Scopes.SINGLETON);
+
+        configBinder(binder).bindConfig(BaseJdbcConfig.class);
+        configBinder(binder).bindConfig(TypeHandlingJdbcConfig.class);


It would be binded in BaseJdbcModules so I guess we might not have to bind here

Praveen2112 · 2020-10-02T13:07:02Z

presto-salesforce/src/main/java/io/prestosql/plugin/salesforce/driver/ForceDriver.java

+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+public class ForceDriver


We can also add services file for this

Praveen2112 · 2020-10-02T13:08:54Z

presto-salesforce/src/main/java/io/prestosql/plugin/salesforce/driver/ForceDriver.java

+        throw new SQLFeatureNotSupportedException();
+    }
+
+    static {


We can move this static method up

Praveen2112 · 2020-10-02T13:15:14Z

presto-salesforce/src/main/java/io/prestosql/plugin/salesforce/driver/metadata/Column.java

+
+import java.io.Serializable;
+
+public class Column


Can we have a builder for it ?

Praveen2112 · 2020-10-02T13:20:25Z

presto-salesforce/src/main/java/io/prestosql/plugin/salesforce/SoqlQueryBuilder.java

+import static java.util.Objects.requireNonNull;
+import static java.util.stream.Collectors.joining;
+
+public class SoqlQueryBuilder


We can extend QueryBuilder ?

Praveen2112 · 2020-10-02T13:23:09Z

presto-salesforce/src/main/java/io/prestosql/plugin/salesforce/driver/ForceModule.java

+        {
+        }).in(Scopes.SINGLETON);
+
+        binder.requestStaticInjection(ForceConnection.class);


Where do we inject this ?

kurtqq · 2021-10-12T16:10:05Z

wonder if there is any progress with the salesforce connector?
This could really make a diffrance

kurtqq · 2022-02-14T21:27:02Z

Could this PR be completed?

mosabua · 2022-10-12T20:17:02Z

Closing after discussion of @bitsondatadev with @pgagnon . If anyone wants to pick this up, feel free to take the code in this PR and adjust as necessary.

cla-bot bot added the cla-signed label Jan 18, 2020

pgagnon force-pushed the salesforce branch 2 times, most recently from 262c062 to 733cd8c Compare January 18, 2020 19:58

pgagnon changed the title ~~Add Salesforce jdbc-based connector~~ Add Salesforce JDBC Connector Jan 18, 2020

pgagnon force-pushed the salesforce branch 5 times, most recently from 0299090 to 7819474 Compare January 19, 2020 18:00

pgagnon marked this pull request as ready for review January 19, 2020 19:25

pgagnon requested review from martint and findepi January 20, 2020 17:35

pgagnon added the syntax-needs-review label Jan 21, 2020

pgagnon force-pushed the salesforce branch 2 times, most recently from aff701e to 14e552f Compare February 7, 2020 17:12

Praveen2112 reviewed Feb 21, 2020

View reviewed changes

Praveen2112 reviewed Feb 23, 2020

View reviewed changes

pgagnon closed this Feb 25, 2020

pgagnon reopened this Feb 25, 2020

pgagnon force-pushed the salesforce branch from 14e552f to 5015292 Compare February 28, 2020 22:21

pgagnon force-pushed the salesforce branch from 5015292 to 3de1d43 Compare April 11, 2020 13:10

tooptoop4 mentioned this pull request Apr 18, 2020

More https://trino.io/resources.html #3472

Closed

martint requested a review from Praveen2112 June 13, 2020 01:14

pgagnon force-pushed the salesforce branch 2 times, most recently from 1a1c169 to e0ac5c5 Compare July 13, 2020 22:01

martint reviewed Sep 28, 2020

View reviewed changes

pgagnon added 2 commits October 21, 2020 16:23

Add Salesforce JDBC Connector

bf6f0ae

Implement credentials provisioning through catalog properties in Sale…

8a5f153

…sforce connector

pgagnon added 23 commits October 21, 2020 16:23

Remove extraneous credentialsConfig binding

e060ed9

Remove presto-salesforce from development config.properties default p…

7341c8d

…lugins list

Update presto-salesforce/pom.xml to version 330-SNAPSHOT

c92216c

Remove ForceSoapValidator

122c378

Rename ParameterMetadataImpl to ForceParameterMetadata

126cabb

Modify ForceResultField hash and equals methods to use Objects functions

860c3be

Make name and type fields mandatory

2ec0fe1

Make FieldDef hash and equals methods take advantage of Objects funct…

b7d5938

…ions

Add salesforce.fetch-size configuration parameter

770ea1c

Improve module configuration code

31887d8

Update pom.xml to 331-SNAPSHOT

3c4d993

Fix checkstyle errors

d96c082

Remove unused argument from getConnectionFactory

4a34b34

Add rudimentary documentation for salesforce connector

4075dc7

Resolve review comments in ForceConnection

ea7cf96

Remove unused import in SalesforceClientModule

48da5bb

Add explicit constructor to ForceConnectionInfo

72ced05

Throw on usage of unimplemented JDBC methods

874f600

Remove dead code related to caching

4b07cd7

Update pom.xml to version 339-SNAPSHOT

8f3f0ee

Migrate to objectMapping instead of blockMapping

50d238c

Fix timezone handling in convertToSoqlParam

f37a406

Fix docs snafu

864d465

pgagnon force-pushed the salesforce branch from be29932 to 864d465 Compare October 21, 2020 20:24

Praveen2112 reviewed Jan 20, 2021

View reviewed changes

findepi force-pushed the master branch from 8538e49 to 1f896ea Compare July 30, 2021 22:14

mosabua closed this Oct 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Salesforce JDBC Connector #2548

Add Salesforce JDBC Connector #2548

pgagnon commented Jan 18, 2020 •

edited

Loading

martint commented Feb 19, 2020

Praveen2112 commented Feb 21, 2020

Praveen2112 left a comment

Praveen2112 Feb 21, 2020

pgagnon Feb 25, 2020

Praveen2112 Feb 23, 2020

pgagnon Apr 11, 2020

martint Sep 28, 2020

pgagnon Sep 28, 2020

Praveen2112 Oct 2, 2020

Praveen2112 Oct 2, 2020

Praveen2112 Oct 2, 2020

Praveen2112 Oct 2, 2020

Praveen2112 Oct 2, 2020

Praveen2112 Oct 2, 2020

Praveen2112 Oct 2, 2020

Praveen2112 Oct 2, 2020

Praveen2112 Oct 2, 2020

Praveen2112 Oct 2, 2020

kurtqq commented Oct 12, 2021

kurtqq commented Feb 14, 2022

mosabua commented Oct 12, 2022

Add Salesforce JDBC Connector #2548

Add Salesforce JDBC Connector #2548

Conversation

pgagnon commented Jan 18, 2020 • edited Loading

martint commented Feb 19, 2020

Praveen2112 commented Feb 21, 2020

Praveen2112 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kurtqq commented Oct 12, 2021

kurtqq commented Feb 14, 2022

mosabua commented Oct 12, 2022

pgagnon commented Jan 18, 2020 •

edited

Loading