Serialize JSON directly from Pages #23975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/json-encoders
branch
5 times, most recently
from
eb9d704
to
f49fc78
Compare
This avoids unnecessary boxing/unboxing for primitive values which are boxed once the `Object getObjectValue` is called on a `Type`. This now fetches primitive values directly and writes them to a JsonGenerator without unboxing.
losipiuk
reviewed
Oct 30, 2024
core/trino-main/src/main/java/io/trino/server/protocol/JsonBytesQueryDataProducer.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 30, 2024
core/trino-main/src/main/java/io/trino/server/protocol/JsonEncodingUtils.java
Show resolved
Hide resolved
losipiuk
approved these changes
Oct 30, 2024
This unifies serialization between the spooled and direct protocols
wendigo
force-pushed
the
serafin/json-encoders
branch
from
f49fc78
to
4c77f76
Compare
wendigo
force-pushed
the
serafin/json-encoders
branch
from
4c77f76
to
b98e65c
Compare
sajjoseph
reviewed
Oct 31, 2024
| @@ -83,8 +83,8 @@ public ResultRows toRows(List<Column> columns, QueryData data) | |||
| } | |||
|
|
|||
| verify(columns != null && !columns.isEmpty(), "Columns must be set when decoding data"); | |||
| if (data instanceof RawQueryData) { | |||
| RawQueryData rawData = (RawQueryData) data; | |||
| if (data instanceof TypedQueryData) { | |||
There was a problem hiding this comment.
can't we short circuit it?
if (data instanceof TypedQueryData rawData) {
There was a problem hiding this comment.
No. This is client so JDK 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids:
Object Type.getObjectValuecalls)Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: