Cast pushdown test case refactoring

[krvikash]

Description

Follow up of #22728 (comment) and #22951 (comment)

Release notes

(X) This is not user-visible or is docs only, and no release notes are required.

[krvikash]

Addressed comments

[ssheikin]

Why not to use different factory methods for CastTestCase ?

[krvikash]

I think its better to have two separate records for success and failed cases. As targetColumn is not necessary in failed case and errorMessage, pushdownErrorMessage is not required for success case.

Introducing factory method

public record CastTestCase(String sourceColumn, String castType, Optional<String> targetColumn, Optional<String> errorMessage, Optional<String> pushdownErrorMessage)
{
  public CastTestCase
  {
      requireNonNull(sourceColumn, "sourceColumn is null");
      requireNonNull(castType, "castType is null");
      requireNonNull(targetColumn, "targetColumn is null");
      requireNonNull(targetColumn, "errorMessage is null");
      requireNonNull(targetColumn, "pushdownErrorMessage is null");
  }

  public CastTestCase castTestCase(String sourceColumn, String castType, String targetColumn)
  {
      return new CastTestCase(sourceColumn, castType, Optional.of(targetColumn), Optional.empty(), Optional.empty());
  }

  public CastTestCase failingCastTestCase(String sourceColumn, String castType)
  {
      return new CastTestCase(sourceColumn, castType, Optional.empty(), Optional.of("(.*)Cannot cast (.*) to (.*)"), Optional.empty());
  }

  public CastTestCase failingCastTestCase(String sourceColumn, String castType, String errorMessage)
  {
      return new CastTestCase(sourceColumn, castType, Optional.empty(), Optional.of(errorMessage), Optional.empty());
  }

  public CastTestCase failingCastTestCase(String sourceColumn, String castType, String errorMessage, String pushdownErrorMessage)
  {
      return new CastTestCase(sourceColumn, castType, Optional.empty(), Optional.of(errorMessage), Optional.of(pushdownErrorMessage));
  }
}

By having 2 separate records.

public record CastTestCase(String sourceColumn, String castType, String targetColumn)
{
    public CastTestCase
    {
        requireNonNull(sourceColumn, "sourceColumn is null");
        requireNonNull(castType, "castType is null");
        requireNonNull(targetColumn, "targetColumn is null");
    }
}

public record FailCastTestCase(String sourceColumn, String castType, String errorMessage, Optional<String> pushdownErrorMessage)
{
    public FailCastTestCase(String sourceColumn, String castType)
    {
        this(sourceColumn, castType, "(.*)Cannot cast (.*) to (.*)");
    }

    public FailCastTestCase(String sourceColumn, String castType, String errorMessage)
    {
        this(sourceColumn, castType, errorMessage, Optional.empty());
    }

    public FailCastTestCase
    {
        requireNonNull(sourceColumn, "sourceColumn is null");
        requireNonNull(castType, "castType is null");
        requireNonNull(errorMessage, "errorMessage is null");
        requireNonNull(pushdownErrorMessage, "pushdownErrorMessage is null");
    }
}

[krvikash]

Thanks @SemionPar @ssheikin @Praveen2112 for the review. Addressed comments.

[krvikash]

(Ready for review)

[Praveen2112]

LGTM. % change

[krvikash]

(rebased with master)