Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract outer symbols from lambda expressions #23649

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Oct 2, 2024

## General
* Fix query failures when complex symbols are referenced from within lambda expression. ({issue}`issuenumber`)

@martint
Copy link
Member

martint commented Oct 2, 2024

Have you found a query that fails due to this? If so, can you add a test with it?

@sopel39
Copy link
Member Author

sopel39 commented Oct 2, 2024

Have you found a query that fails due to this? If so, can you add a test with it?

Maybe something like InlineProjections, where it now works for:

y := transform(array, x -> x + i)
|
array := ...
i := j * 2

but I'm not sure it should actually inline in that case event though i is referenced once...

@sopel39 sopel39 merged commit 88ff52e into trinodb:master Oct 3, 2024
12 checks passed
@sopel39 sopel39 deleted the ks/extract_outer branch October 3, 2024 12:02
@sopel39
Copy link
Member Author

sopel39 commented Oct 3, 2024

added test

@github-actions github-actions bot added this to the 460 milestone Oct 3, 2024
@mosabua mosabua mentioned this pull request Oct 3, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants