Update queryType list in selector rules docs #23635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blvckcoffee
force-pushed
the
jj/selector-rule-query-types
branch
from
308fc28
to
44b01fd
Compare
|
I think at least in Trino we should link all of them to the SQL statement |
blvckcoffee
force-pushed
the
jj/selector-rule-query-types
branch
from
44b01fd
to
01b4a52
Compare
mosabua
requested changes
Oct 1, 2024
|
Also one last request .. please break this into two commits. One for rewording and adding links to the existing docs, and one for adding missing ones. Let me know if I can help with breaking the commits apart and how to do that |
blvckcoffee
force-pushed
the
jj/selector-rule-query-types
branch
from
01b4a52
to
ac4622e
Compare
ebyhr
reviewed
Oct 2, 2024
blvckcoffee
force-pushed
the
jj/selector-rule-query-types
branch
from
ac4622e
to
e53e347
Compare
Add links to SQL commands and improve grammar
blvckcoffee
force-pushed
the
jj/selector-rule-query-types
branch
from
e53e347
to
e0c2bbc
Compare
mosabua
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MERGEandALTER_TABLE_EXECUTEto list of queryType options for resource group selector rules.Additional context and related issues
trino/core/trino-spi/src/main/java/io/trino/spi/resourcegroups/QueryType.java
Line 16 in 460beff
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: