Remove atop connector #23550
Merged
Remove atop connector #23550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The two test failures are false alarms and unrelated failures. |
dain
approved these changes
Sep 25, 2024
ebyhr
reviewed
Sep 25, 2024
...src/main/java/io/trino/tests/product/launcher/env/environment/EnvMultinodeAllConnectors.java
Show resolved
Hide resolved
ebyhr
approved these changes
Sep 26, 2024
raunaqmorarka
approved these changes
Sep 26, 2024
The connector has very limited use since it only works with the atop command. Much more modern monitoring tools are in standard use now and replace usage of atop. In a contributor call, on slack and in other conversations no concerns were expressed by anybody about the removal.
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) Release notes are required, with the following suggested text:
## General Remove Atop connector.