Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use upper bounded wildcard to read and delete cookie #23539

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Use upper bounded wildcard to read and delete cookie #23539

merged 1 commit into from
Sep 24, 2024

Conversation

krvikash
Copy link
Contributor

@krvikash krvikash commented Sep 24, 2024 •
edited
Loading

Description

Use upper bounded wildcard to read and delete cookie. It will help to use same api to read and delete NewCookie.

@cla-bot cla-bot bot added the cla-signed label Sep 24, 2024
ksobolew
ksobolew approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@ksobolew ksobolew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also OAuthIdTokenCookie, AFAICT

@krvikash krvikash force-pushed the krvikash/OAuthWebUiCookie-change branch from 60225b1 to 2ed839f Compare September 24, 2024 07:12
@krvikash krvikash changed the title Use upper bounded wildcard to read and delete cookie in OAuthWebUiCookie Use upper bounded wildcard to read and delete cookie Sep 24, 2024
@krvikash
Copy link
Contributor Author

Thanks @ksobolew for the review. Added OAuthIdTokenCookie as well.

@wendigo wendigo merged commit 9f9576f into trinodb:master Sep 24, 2024
94 checks passed
@krvikash krvikash deleted the krvikash/OAuthWebUiCookie-change branch September 24, 2024 17:51
@github-actions github-actions bot added this to the 459 milestone Sep 24, 2024
@mosabua
Copy link
Member

mosabua commented Sep 25, 2024

I assume no release note entry needed @wendigo and @krvikash .. note please use template or label to indicate on each PR.

@mosabua mosabua mentioned this pull request Sep 25, 2024
Merged
@wendigo
Copy link
Contributor

wendigo commented Sep 25, 2024

@mosabua no, this is helper util :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksobolew ksobolew ksobolew approved these changes

@wendigo wendigo wendigo approved these changes

@Praveen2112 Praveen2112 Awaiting requested review from Praveen2112

@marcinsbd marcinsbd Awaiting requested review from marcinsbd

Assignees
No one assigned
Labels
cla-signed
Milestone
459
Development

Successfully merging this pull request may close these issues.
4 participants
@krvikash @mosabua @wendigo @ksobolew