Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConnectorAccessControl to ConnectorMetadata.getTableHandleForExecute #23524

Merged

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Sep 22, 2024

Description

CALL syntax allows ConnectorAccessControl in procedures, but ALTER TABLE ... EXECUTE syntax doesn't support it. This PR updates ConnectorMetadata.getTableHandleForExecute method so that developers can use the access control in their table procedures. Injecting the interface doesn't work well when system security is used.

Release notes

# SPI
* Add `ConnectorAccessControl` argument to `ConnectorMetadata.getTableHandleForExecute` method. ({issue}`23524`)

@cla-bot cla-bot bot added the cla-signed label Sep 22, 2024
@github-actions github-actions bot added iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector labels Sep 22, 2024
@ebyhr ebyhr force-pushed the ebi/alter-table-execute-connector-access-control branch from ca39bcd to 1146a59 Compare September 22, 2024 03:53
@ebyhr ebyhr merged commit addda4a into trinodb:master Sep 23, 2024
94 checks passed
@ebyhr ebyhr deleted the ebi/alter-table-execute-connector-access-control branch September 23, 2024 21:38
@github-actions github-actions bot added this to the 459 milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector hive Hive connector iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

2 participants