Pushdown CAST in JOIN criteria for PostgreSql #21939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ssheikin
commented
May 13, 2024
| @@ -1013,6 +1012,66 @@ public void testInPredicatePushdown() | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Add case sensitive tests
ssheikin
force-pushed
the
ssheikin/95/trino/cast-pushdown
branch
from
2b19480
to
07e7da2
Compare
ssheikin
commented
May 13, 2024
Comment on lines
+1075
to
+1073
| assertThatThrownBy(() -> getQueryRunner().execute(session, "SELECT a.a2, b.b2 FROM %s a JOIN %s b ON CAST(a.a1 AS %s) = b.b1".formatted(tableA.getName(), tableB.getName(), testCaseMoney.castType()))); | ||
| // the best we can do - cast right side to a trino type, to which is resolved left side. After pushdown, trino type is mapped to native type | ||
| assertThat(query(session, "SELECT a.a2, b.b2 FROM %s a JOIN %s b ON CAST(a.a1 AS %s) = CAST(b.b1 AS %s)".formatted(tableA.getName(), tableB.getName(), testCaseMoney.castType(), testCaseMoney.castType()))) |
There was a problem hiding this comment.
This is a breaking change, so has to be covered by config/session property toggle.
@Praveen2112
ssheikin
force-pushed
the
ssheikin/95/trino/cast-pushdown
branch
from
07e7da2
to
d4f22da
Compare
Extend rule to support join pushdown in cases where join conditions contain Calls causing Project nodes to appear over scans. Fix failing tests
Co-authored-by: Semion Paramonow <[email protected]>
ssheikin
force-pushed
the
ssheikin/95/trino/cast-pushdown
branch
from
d4f22da
to
edc25bf
Compare
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
I am adding the stale-ignore label under the assumption that @ssheikin and others are still collaborating on this and will bring it to completion. |
mosabua
added
stale-ignore
|
To revisit after #21607 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be revisited after #22728 is merged
Description
Based and requires #21607
Similar to #22728
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: